Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tf][py] Update function names #14487

Merged
merged 4 commits into from
Aug 1, 2023
Merged

[tf][py] Update function names #14487

merged 4 commits into from
Aug 1, 2023

Conversation

jpienaar
Copy link
Member

Not sure how these are working, this should be without suffix (unless I messed up bumping).

Not sure how these are working, this should be without suffix (unless I messed up bumping).
@ShuaiShao93
Copy link

Can we add a unit test that can catch this? Preferably without using notebooks, so that it can catch the problems better

@jpienaar jpienaar requested a review from pzread August 1, 2023 14:26
@pzread
Copy link
Contributor

pzread commented Aug 1, 2023

It looks like the job python_release_packages is hanging. I checked the runner and it seems idle. Some commands the runner is waiting on:

runner     11855   11842  0 15:20 ?        00:00:02 docker run --rm -v /runner-root/actions-runner/_work/iree/iree:/runner-root/actions-runner/_work/iree/iree -v /runner-root/actions-runner/_work/iree/iree/bindist:/runner-root/actions-runner/_work/iree/iree/bindist -e __MANYLINUX_BUILD_WHEELS_IN_DOCKER=1 -e override_python_versions=cp38-cp38 -e packages=iree-compiler -e package_suffix= -e output_dir=/runner-root/actions-runner/_work/iree/iree/bindist gcr.io/iree-oss/manylinux2014_x86_64-release@sha256:e83893d35be4ce3558c989e9d5ccc4ff88d058bc3e74a83181059cc76e2cf1f8 -- /runner-root/actions-runner/_work/iree/iree/build_tools/python_deploy/build_linux_packages.sh
root       34813   15100  0 15:31 ?        00:00:00 /bin/sh -c cd /runner-root/actions-runner/_work/iree/iree/compiler/build/cmake_build/runtime/src/iree/modules/check/test && /runner-root/actions-runner/_work/iree/iree/compiler/build/cmake_build/tools/iree-compile --output-format=vm-bytecode --mlir-print-op-on-diagnostic=false --iree-hal-target-backends=vmvx /runner-root/actions-runner/_work/iree/iree/runtime/src/iree/modules/check/test/success.mlir -o check_vmvx_local-task_success.mlir_module.vmfb --iree-hal-executable-object-search-path=\"/runner-root/actions-runner/_work/iree/iree/compiler/build/cmake_build\"
root       34829   34813  0 15:31 ?        00:00:00 /runner-root/actions-runner/_work/iree/iree/compiler/build/cmake_build/tools/iree-compile --output-format=vm-bytecode --mlir-print-op-on-diagnostic=false --iree-hal-target-backends=vmvx /runner-root/actions-runner/_work/iree/iree/runtime/src/iree/modules/check/test/success.mlir -o check_vmvx_local-task_success.mlir_module.vmfb --iree-hal-executable-object-search-path="/runner-root/actions-runner/_work/iree/iree/compiler/build/cmake_build"

@jpienaar
Copy link
Member Author

jpienaar commented Aug 1, 2023

Should I just rebase and upload to unstick?

@pzread
Copy link
Contributor

pzread commented Aug 1, 2023

Should I just rebase and upload to unstick?

Yes, I think we can try

@@ -7,3 +7,4 @@
# Re-export some legacy APIs from the tools package to this top-level.
# TODO: Deprecate and remove these names once clients are migrated.
from .tools import *
version = 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason we need to put this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I think this is is a bad snaphot, not intentional

@jpienaar jpienaar enabled auto-merge (squash) August 1, 2023 17:32
@jpienaar jpienaar merged commit e86779d into main Aug 1, 2023
50 checks passed
@jpienaar jpienaar deleted the jpienaar-patch-3 branch August 1, 2023 18:27
nhasabni pushed a commit to plaidml/iree that referenced this pull request Aug 24, 2023
Not sure how these are working, this should be without suffix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants