-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tf][py] Update function names #14487
Conversation
Not sure how these are working, this should be without suffix (unless I messed up bumping).
Can we add a unit test that can catch this? Preferably without using notebooks, so that it can catch the problems better |
It looks like the job
|
Should I just rebase and upload to unstick? |
Yes, I think we can try |
@@ -7,3 +7,4 @@ | |||
# Re-export some legacy APIs from the tools package to this top-level. | |||
# TODO: Deprecate and remove these names once clients are migrated. | |||
from .tools import * | |||
version = 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason we need to put this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I think this is is a bad snaphot, not intentional
Not sure how these are working, this should be without suffix.
Not sure how these are working, this should be without suffix (unless I messed up bumping).