[HIP] Adds basics to implement HIP HAL driver #15506
Conversation
nithinsubbiah
requested review from
benvanik and
stellaraccident
as code owners
nithinsubbiah
requested review from
antiagainst
and removed request for
benvanik and
stellaraccident
nithinsubbiah
force-pushed
the
hip_backend
branch
from
3108cb4
to
f7ebf0e
Compare
|
Thanks for the patch! I didn't get to it today; will take a look tomorrow. |
|
BTW, when addressing comments, please add additional commits (no force push) so that it's easier to identify what's changed. If you want to sync up with |
This commit starts a HIP backend in HAL. Following the steps of CUDA rewrite (iree-org#13245) effort, this backend will provide improvements over the existing ROCm HAL backend. Building this commmit with -DIREE_EXTERNAL_HAL_DRIVERS=hip will initialize this driver and the driver information can be seen using `tools/iree-run-module --dump_devices`.
nithinsubbiah
force-pushed
the
hip_backend
branch
from
f7ebf0e
to
08c7996
Compare
Addresses comments from the earlier patch
nithinsubbiah
force-pushed
the
hip_backend
branch
from
08c7996
to
ffa42ec
Compare
Sorry, I didn't know the convention and I had already rebased and started addressing comments before I saw this. Will follow the right steps from next patch. |
experimental/hip/status_util.c
Outdated
| #include "experimental/hip/dynamic_symbols.h" | ||
| #include "iree/base/status.h" | ||
|
|
||
| // TODO: Map HIP error strings with their corresponding IREE error state |
There was a problem hiding this comment.
Are you planning to do this next?
Also fixes formatting
There was a problem hiding this comment.
Thanks for addressing the comments; LGTM now! But don't submit yet; we'd like @benvanik to take a look too.
|
@benvanik ping for review |
|
@antiagainst could you please merge since I don't have write access? |
This commit starts a HIP backend in HAL. Following the steps of the new CUDA backend (`cuda2`) (iree-org#13245) effort, HIP will provide enhancements over existing ROCm HAL backend which is based on the current CUDA backend. This commit can be built with `-DIREE_EXTERNAL_HAL_DRIVERS=hip` which will initialize the HIP driver. Device registration can be verified using `tools/iree-run-module --dump_devices`.
This commit starts a HIP backend in HAL. Following the steps of the new CUDA backend (
cuda2) (#13245) effort, HIP will provide enhancements over existing ROCm HAL backend which is based on the current CUDA backend. This commit can be built with-DIREE_EXTERNAL_HAL_DRIVERS=hipwhich will initialize the HIP driver. Device registration can be verified usingtools/iree-run-module --dump_devices.