[CPU] Remove unnecessary factors from getMaxVectorTileSize. #15843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no lower_bound and upper_bound context in vector tile size. We should just use the number of elements factor. It removes `lb` and `ub`; it asks users to provide the number of elements directly. It also removes `allowIncomplteTile` because this factor should already be modeld by `enforcePowerOfTwo`.
hanhanW
force-pushed
the
clean-get-max-vector-size
branch
from
63d1b46
to
b8bcec8
Compare
hanhanW
added
benchmarks:x86_64
|
I want to claim this as an NFC but I remove the logics about We likely don't hit the branch when computing vector sizes, so it does not impact any lit tests and benchmark results. It looks like a good cleanup to me. @dcaballe what do you think? |
pzread
approved these changes
Dec 11, 2023
| @@ -854,9 +838,6 @@ static LogicalResult setMatmulNoPadRootConfig( | |||
| const SmallVectorImpl<bool> &vecScalableDims = inputScalableTileFlags.back(); | |||
| SmallVector<int64_t> parallelTileSizes; | |||
| SmallVector<bool> parallelScalableFlags; | |||
| bool allowIncompleteTile = | |||
| vecPreProcStrategy == VectorPreProcStrategy::Peeling || | |||
| vecPreProcStrategy == VectorPreProcStrategy::Masking; | |||
There was a problem hiding this comment.
Do we need to assert if the strategy is not one of these?
There was a problem hiding this comment.
I think it is okay because all the matmul strategy is using peeling or masking. At least it is the case for targets we've been actively working on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no lower_bound and upper_bound context in vector tile size. We should just use the number of elements factor. It removes
lbandub; it asks users to provide the number of elements directly.It also removes
allowIncomplteTilebecause this factor should already be modeld byenforcePowerOfTwo.