Add swizziling using transform dialect #16248
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erman-gurses
force-pushed
the
swizziling-transform-dialect
branch
4 times, most recently
from
6e67f25
to
8119319
Compare
erman-gurses
force-pushed
the
swizziling-transform-dialect
branch
from
8119319
to
fbddd0e
Compare
|
I don't see any IREE specific logics. Shouldn't we add the transform op upstream and use it in IREE? Do we plan to upstream them later? |
|
Yeah good point. @harsh-nod and @erman-gurses can we add this upstream? |
|
Can you not just run the pass directly? https://mlir.llvm.org/docs/Dialects/Transform/#transformapply_registered_pass-transformapplyregisteredpassop |
@MaheshRavishankar, @hanhanW, @Groverkss, I will look for a way to do that. |
|
Two PRs are landed to LLVM upstream regarding this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It connects the swizzling algorithm in the upstream LLVM with IREE using transform dialect.
See the LLVM upstream implementation: llvm/llvm-project#79164