-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow flags to be set with greater flexibility #17659
Conversation
Signed-off-by: Dave Liddell <dave.liddell@amd.com> Signed-off-by: daveliddell <dave.liddell@amd.com>
f3d76a3
to
7d94e5d
Compare
Please hold off reviewing; will rework client of this API not to use the driver cache, so will git rid of unnecessary new features |
Snippet of ugly but functional use of this new feature:
|
General note: in an offline discussion, we decided to keep the cache, so this PR is still a go. Making it ready-for-review again |
Signed-off-by: Dave Liddell <dave.liddell@amd.com>
New sample usage:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving but please make the requested changes to the flag vector before landing as it has a subtle bug how it is.
Signed-off-by: Dave Liddell <dave.liddell@amd.com>
CI failure is preexisting and unrelated to this change, merging through it.
|
Changes to the python binding to allow iree.runtime.flags.parse_flags to take effect at times other than before the first time a driver is created. Also includes fixes for bugs exposed during the development of this feature.
create_hal_driver()
andclear_hal_driver_cache()
to create a driver object independent of the cache, and to clear the cache, respectivelyHalDriver
class implementation functions for the above new API functions. Refactored class to share as much common code as possible.