[Flow] Always permute the accesses on inputs for elementwise consumer from namedop/reduction producer. #17663
+35
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaheshRavishankar
force-pushed
the
consumer_nonidentity_access
branch
from
f352fe0
to
195f999
Compare
MaheshRavishankar
added
benchmarks:cuda
Abbreviated Benchmark Summary@ commit 50035d59537fa95e5b3d8b194b6c0883b87f1395 (vs. base 7b58c712a1c6bc1a13fc4525ef07b0030a950d86) Data-Tiling Comparison TableClick to show
Regressed Latencies 🚩
[Top 3 out of 5 results showed] Improved Latencies 🎉
[Top 3 out of 13 results showed] Regressed Total Dispatch Sizes 🚩
[Top 3 out of 12 results showed] Improved Stream IR Dispatch Count (# of cmd.dispatch ops) 🎉
[Top 3 out of 29 results showed] For more information: |
… from namedop/reduction producer. For dispatch formation, the current logic (and a lot of code-generation) works much better if the consumer uses an identity indexing map for the producer. There is already a pass in dispatch region formation flow that does this for just a convolution op. Make this apply for more general cases. Signed-off-by: MaheshRavishankar <mahesh.ravishankar@gmail.com>
MaheshRavishankar
force-pushed
the
consumer_nonidentity_access
branch
from
195f999
to
f68153c
Compare
|
Fixes nod-ai/SHARK-Turbine#747 |
benvanik
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For dispatch formation, the current logic (and a lot of code-generation) works much better if the consumer uses an identity indexing map for the producer. There is already a pass in dispatch region formation flow that does this for just a convolution op. Make this apply for more general cases.