Add workgroup chipletgroup strategy to workgroup reordering pass #17811
+399
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
bangtianliu
requested review from
MaheshRavishankar,
qedawkins,
kuhar,
Groverkss and
antiagainst
as code owners
kuhar
requested changes
Jul 8, 2024
compiler/src/iree/compiler/Codegen/Common/GPU/WorkgroupReordering.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Common/GPU/WorkgroupReordering.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Common/GPU/WorkgroupReordering.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Common/GPU/WorkgroupReordering.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Common/GPU/WorkgroupReordering.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Dialect/GPU/IR/IREEGPUAttrs.td
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/LLVMGPU/LLVMGPULowerExecutableTarget.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/LLVMGPU/LLVMGPULowerExecutableTarget.cpp
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/LLVMGPU/test/ROCDL/config_user_vector_distribute.mlir
Outdated
Show resolved
Hide resolved
Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
|
Added a new attribute about number of XCDs on GPUs, but still need to check this pass's correctness futher |
Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
kuhar
reviewed
Jul 10, 2024
| makeChipletGroupedIds(Location loc, OpBuilder b, Value workgroupIdX, | ||
| Value workgroupIdY, Value workgroupCountX, | ||
| Value workgroupCountY, unsigned chipletGroupTile) { | ||
| // Create one dimension ID for workgroup |
compiler/src/iree/compiler/Codegen/Common/GPU/WorkgroupReordering.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
kuhar
reviewed
Jul 10, 2024
compiler/src/iree/compiler/Codegen/Common/GPU/WorkgroupReordering.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Common/GPU/WorkgroupReordering.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Common/GPU/WorkgroupReordering.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Common/GPU/WorkgroupReordering.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Common/GPU/WorkgroupReordering.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Common/GPU/WorkgroupReordering.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Dialect/GPU/IR/IREEGPUAttrs.td
Outdated
Show resolved
Hide resolved
Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
kuhar
reviewed
Jul 10, 2024
compiler/src/iree/compiler/Codegen/Common/GPU/WorkgroupReordering.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Common/GPU/WorkgroupReordering.cpp
Outdated
Show resolved
Hide resolved
| // Step 1: Reorder the workgroup grid to move slowly between | ||
| // chiplet groups (Function: chipletAwareWorkgroupReordering). | ||
| // Step 2: Implement 'super-grouping' of workgroups before switching to the next | ||
| // column. |
Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
kuhar
reviewed
Jul 10, 2024
compiler/src/iree/compiler/Codegen/Common/GPU/WorkgroupReordering.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
kuhar
reviewed
Jul 11, 2024
Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
qedawkins
reviewed
Jul 11, 2024
compiler/src/iree/compiler/Codegen/Common/GPU/WorkgroupReordering.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Common/GPU/WorkgroupReordering.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Common/GPU/WorkgroupReordering.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Common/GPU/WorkgroupReordering.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Common/GPU/WorkgroupReordering.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Dialect/GPU/IR/IREEGPUAttrs.td
Outdated
Show resolved
Hide resolved
kuhar
reviewed
Jul 11, 2024
Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new option, "chipletgroup," has been added to the existing options {none, swizzle, transpose}, making it {none, swizzle, transpose, chipletgroup}.
The new attribute #iree_gpu.reorder_workgroups has been introduced. You can refer to the IR test file (e.g., config_user_vector_distribute.mlir) to learn how to enable workgroup reordering in the configuration entries.