Add a Flow specific canonicalizer pass #17836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qedawkins
added
the
benchmarks:comp-stats
Abbreviated Benchmark Summary@ commit 3aa48fc1d0ca8ddd99f4b840da20bc12483d08b2 (vs. base 429aafd877536c0efca7cd0865c98b3692ec9728) No improved or regressed compilation metrics 🏖️ For more information: |
MaheshRavishankar
requested changes
Jul 9, 2024
compiler/src/iree/compiler/Dialect/Flow/Transforms/Canonicalizer.cpp
Outdated
Show resolved
Hide resolved
Certain patterns that are borderline canonicalizations or better suited as a canonical form for certain phases benefit from having a phase specific canonicalization pass. The only pattern added here for now is consecutive insert/extract slice folding which is always beneficial in Flow, but not in Codegen.
qedawkins
force-pushed
the
flow_canonicalize
branch
from
38031ec
to
cfba042
Compare
MaheshRavishankar
approved these changes
Jul 12, 2024
LLITCHEV
pushed a commit
to LLITCHEV/iree
that referenced
this pull request
Jul 30, 2024
Certain patterns that are borderline canonicalizations or better suited as a canonical form for certain phases benefit from having a phase specific canonicalization pass. The only pattern added here for now is consecutive insert/extract slice folding which is always beneficial in Flow, but not in Codegen. Signed-off-by: Lubo Litchev <lubol@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain patterns that are borderline canonicalizations or better suited as a canonical form for certain phases benefit from having a phase specific canonicalization pass. The only pattern added here for now is consecutive insert/extract slice folding which is always beneficial in Flow, but not in Codegen.