Drop unmaintained transform dialect tests #17858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests in `tests/transform_dialect` have been unmaintained (and mostly disabled) for a while. Most of the tests were misplaced anyway, mixing lit tests in with e2e tests, and much of the relevant functionality is now tested upstream or has evolved into different lit tests in Codegen. This drops the entire `cuda` directory, and drops all `cpu` tests except one which is testing a transform dialect library call, which is still a relevant e2e test.
qedawkins
force-pushed
the
drop_transform_dialect_e2e_tests
branch
from
694dd36
to
a7d2f55
Compare
ScottTodd
approved these changes
Jul 10, 2024
saienduri
pushed a commit
to saienduri/iree
that referenced
this pull request
Jul 12, 2024
The tests in `tests/transform_dialect` have been unmaintained (and mostly disabled) for a while. Most of the tests were misplaced anyway, mixing lit tests in with e2e tests, and much of the relevant functionality is now tested upstream or has evolved into different lit tests in Codegen. This drops the entire `cuda` directory, and drops all `cpu` tests except one which is testing a transform dialect library call, which is still a relevant e2e test.
saienduri
pushed a commit
to saienduri/iree
that referenced
this pull request
Jul 12, 2024
The tests in `tests/transform_dialect` have been unmaintained (and mostly disabled) for a while. Most of the tests were misplaced anyway, mixing lit tests in with e2e tests, and much of the relevant functionality is now tested upstream or has evolved into different lit tests in Codegen. This drops the entire `cuda` directory, and drops all `cpu` tests except one which is testing a transform dialect library call, which is still a relevant e2e test. Signed-off-by: saienduri <saimanas.enduri@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests in
tests/transform_dialecthave been unmaintained (and mostly disabled) for a while. Most of the tests were misplaced anyway, mixing lit tests in with e2e tests, and much of the relevant functionality is now tested upstream or has evolved into different lit tests in Codegen.This drops the entire
cudadirectory, and drops allcputests except one which is testing a transform dialect library call, which is still a relevant e2e test.