Deflake ScopeTest.WaitIdleFailure by increasing sleep time. #17859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benvanik
approved these changes
Jul 11, 2024
saienduri
pushed a commit
to saienduri/iree
that referenced
this pull request
Jul 12, 2024
…#17859) This test has flaked a few times: * https://github.com/iree-org/iree/actions/runs/9653016869/job/26624436852#step:5:1882 * https://github.com/iree-org/iree/actions/runs/9716312176/job/26819673196#step:4:18786 ``` [ RUN ] ScopeTest.WaitIdleFailure /work/runtime/src/iree/task/scope_test.cc:225: Failure Value of: iree_task_scope_is_idle(&scope) Actual: true Expected: false [ FAILED ] ScopeTest.WaitIdleFailure (175 ms) [----------] 9 tests from ScopeTest (326 ms total) [----------] Global test environment tear-down [==========] 9 tests from 1 test suite ran. (326 ms total) [ PASSED ] 8 tests. [ FAILED ] 1 test, listed below: [ FAILED ] ScopeTest.WaitIdleFailure 1 FAILED TEST ``` We could instead drop the `EXPECT_FALSE(iree_task_scope_is_idle(&scope));` check entirely. Increasing the sleep time will increase test time regardless of OS scheduler behavior (unlike iree-org#17857 which increased a _timeout_ duration).
saienduri
pushed a commit
to saienduri/iree
that referenced
this pull request
Jul 12, 2024
…#17859) This test has flaked a few times: * https://github.com/iree-org/iree/actions/runs/9653016869/job/26624436852#step:5:1882 * https://github.com/iree-org/iree/actions/runs/9716312176/job/26819673196#step:4:18786 ``` [ RUN ] ScopeTest.WaitIdleFailure /work/runtime/src/iree/task/scope_test.cc:225: Failure Value of: iree_task_scope_is_idle(&scope) Actual: true Expected: false [ FAILED ] ScopeTest.WaitIdleFailure (175 ms) [----------] 9 tests from ScopeTest (326 ms total) [----------] Global test environment tear-down [==========] 9 tests from 1 test suite ran. (326 ms total) [ PASSED ] 8 tests. [ FAILED ] 1 test, listed below: [ FAILED ] ScopeTest.WaitIdleFailure 1 FAILED TEST ``` We could instead drop the `EXPECT_FALSE(iree_task_scope_is_idle(&scope));` check entirely. Increasing the sleep time will increase test time regardless of OS scheduler behavior (unlike iree-org#17857 which increased a _timeout_ duration). Signed-off-by: saienduri <saimanas.enduri@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test has flaked a few times:
We could instead drop the
EXPECT_FALSE(iree_task_scope_is_idle(&scope));check entirely. Increasing the sleep time will increase test time regardless of OS scheduler behavior (unlike #17857 which increased a timeout duration).