Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump goldentime values for mi250 sdxl benchmarks. #17860

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

ScottTodd
Copy link
Collaborator

Seeing some variance causing CI failures with unrelated changes:

Aside: we might want to move the benchmarks to a pkgci_benchmarks.yml workflow instead of chaining them on to the end of pkgci_regression_test.yml.

ci-exactly: build_packages,regression_test

@ScottTodd ScottTodd requested a review from saienduri July 10, 2024 23:34
Copy link
Contributor

@saienduri saienduri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, yeah that would be cleaner

@ScottTodd ScottTodd merged commit b67fef7 into iree-org:main Jul 11, 2024
45 checks passed
@ScottTodd ScottTodd deleted the benchmark-thresholds branch July 11, 2024 00:59
saienduri pushed a commit to saienduri/iree that referenced this pull request Jul 12, 2024
Seeing some variance causing CI failures with unrelated changes:
*
https://github.com/iree-org/iree/actions/runs/9879301822/job/27286342282#step:15:46
  * `VAE Decode Benchmark Time: 295.0 ms (golden time 291.0 ms)`
  * `Prompt Encoder Benchmark Time: 17.2 ms (golden time 17.0 ms)`
*
https://github.com/iree-org/iree/actions/runs/9877397187/job/27279465007
  * `VAE Decode Benchmark Time: 295.0 ms (golden time 291.0 ms)`
  * `Prompt Encoder Benchmark Time: 17.1 ms (golden time 17.0 ms)`

Aside: we might want to move the benchmarks to a `pkgci_benchmarks.yml`
workflow instead of chaining them on to the end of
`pkgci_regression_test.yml`.

ci-exactly: build_packages,regression_test
saienduri pushed a commit to saienduri/iree that referenced this pull request Jul 12, 2024
Seeing some variance causing CI failures with unrelated changes:
*
https://github.com/iree-org/iree/actions/runs/9879301822/job/27286342282#step:15:46
  * `VAE Decode Benchmark Time: 295.0 ms (golden time 291.0 ms)`
  * `Prompt Encoder Benchmark Time: 17.2 ms (golden time 17.0 ms)`
*
https://github.com/iree-org/iree/actions/runs/9877397187/job/27279465007
  * `VAE Decode Benchmark Time: 295.0 ms (golden time 291.0 ms)`
  * `Prompt Encoder Benchmark Time: 17.1 ms (golden time 17.0 ms)`

Aside: we might want to move the benchmarks to a `pkgci_benchmarks.yml`
workflow instead of chaining them on to the end of
`pkgci_regression_test.yml`.

ci-exactly: build_packages,regression_test
Signed-off-by: saienduri <saimanas.enduri@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants