Round up sdxl golden dispatch sizes and mi250 times by 10%. #17879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like to rebase the integration PR on top of this and see if regression tests will pass. |
saienduri
pushed a commit
to saienduri/iree
that referenced
this pull request
Jul 12, 2024
…#17879) See [this discussion on Discord](https://discord.com/channels/689900678990135345/689957613152239638/1261059802214305913). These are change detector tests with _some_ use, but exact checking is too noisy and is causing significant churn across PRs and postsubmit CI runs. We could change the test script to allow a certain error range, but for now just increase the thresholds used in `<=` checks by about 10% (then drop a few digits to 0 so we don't give the appearance of high precision). ci-exactly: build_packages,regression_test
saienduri
pushed a commit
to saienduri/iree
that referenced
this pull request
Jul 12, 2024
…#17879) See [this discussion on Discord](https://discord.com/channels/689900678990135345/689957613152239638/1261059802214305913). These are change detector tests with _some_ use, but exact checking is too noisy and is causing significant churn across PRs and postsubmit CI runs. We could change the test script to allow a certain error range, but for now just increase the thresholds used in `<=` checks by about 10% (then drop a few digits to 0 so we don't give the appearance of high precision). ci-exactly: build_packages,regression_test Signed-off-by: saienduri <saimanas.enduri@amd.com>
LLITCHEV
pushed a commit
to LLITCHEV/iree
that referenced
this pull request
Jul 30, 2024
…#17879) See [this discussion on Discord](https://discord.com/channels/689900678990135345/689957613152239638/1261059802214305913). These are change detector tests with _some_ use, but exact checking is too noisy and is causing significant churn across PRs and postsubmit CI runs. We could change the test script to allow a certain error range, but for now just increase the thresholds used in `<=` checks by about 10% (then drop a few digits to 0 so we don't give the appearance of high precision). ci-exactly: build_packages,regression_test Signed-off-by: Lubo Litchev <lubol@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this discussion on Discord.
These are change detector tests with some use, but exact checking is too noisy and is causing significant churn across PRs and postsubmit CI runs. We could change the test script to allow a certain error range, but for now just increase the thresholds used in
<=checks by about 10% (then drop a few digits to 0 so we don't give the appearance of high precision).ci-exactly: build_packages,regression_test