Basic support for building on windows (reapply after revert). #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottTodd
approved these changes
Oct 14, 2019
* Requires clang-cl * Spews a bunch of warning about benign redefinitions and unknown command line arguments (needs triage). * Allows building of iree/tools/run_module and iree/tools/iree-run-mlir, which together, account for building most of the non-test assets. iree-org#19 Fix path issue in lit test runner so it works on Windows under msys2. With this, all of the iree/compiler/... tests build/pass. iree-org#19 Filter for the lit RUN line (not just first line). This allows the e2e tests that include comments first to function. I really need to get lit working properly but this gets us to the point where all of the compiler and e2e tests work (on Windows too). Make the lit RUN line matching more robust. Fix argument command line parsing to trim options. This has the side effect of getting most compiler and e2e tests running on Windows, although some are failing (for unknown reasons). Closes iree-org#23 iree-org#19 Edit positional command arguments in place.
stellaraccident
force-pushed
the
winbuild
branch
from
adcd66a
to
d94b043
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
command line arguments (needs triage).
which together, account for building most of the non-test assets.
#19
Fix path issue in lit test runner so it works on Windows under msys2.
With this, all of the iree/compiler/... tests build/pass.
#19
Filter for the lit RUN line (not just first line).
This allows the e2e tests that include comments first to function.
I really need to get lit working properly but this gets us to the point
where all of the compiler and e2e tests work (on Windows too).
Make the lit RUN line matching more robust.
Fix argument command line parsing to trim options.
This has the side effect of getting most compiler and e2e tests running
on Windows, although some are failing (for unknown reasons).
Closes #23
#19
Edit positional command arguments in place.