Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leaks under vm/test #6142

Merged
merged 1 commit into from
Jun 8, 2021
Merged

Conversation

simon-camp
Copy link
Contributor

No description provided.

Copy link
Contributor

@GMNGeoffrey GMNGeoffrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh I wonder why these weren't caught by the asan build and listed in #5715

@GMNGeoffrey GMNGeoffrey merged commit da141ef into iree-org:main Jun 8, 2021
@simon-camp simon-camp deleted the vm-asan branch June 9, 2021 10:27
@simon-camp
Copy link
Contributor Author

These must have been introduced fairly recently, in the last two weeks or so.

@GMNGeoffrey
Copy link
Contributor

Yeah but we have an asan presubmit that should be catching such things. How did you detect them?

@simon-camp
Copy link
Contributor Author

These failed with my local asan build, but I was also surprised the bot didn't fail.

@GMNGeoffrey
Copy link
Contributor

Can you post the command you ran? I can diff it against what the bot is doing

@NatashaKnk NatashaKnk mentioned this pull request Jun 9, 2021
@simon-camp
Copy link
Contributor Author

I'm using the VSCode CMake extension so this might be overly verbose 🤷‍♂️

Configure
/usr/local/bin/cmake --no-warn-unused-cli -DIREE_HAL_DRIVERS_TO_BUILD=all -DIREE_TARGET_BACKENDS_TO_BUILD=all -DCMAKE_C_COMPILER:STRING=clang-10 -DCMAKE_CXX_COMPILER:STRING=clang++-10 -DIREE_USE_LINKER:STRING=lld-10 -DIREE_ENABLE_ASAN:STRING=ON -DIREE_ENABLE_EMITC:STRING=OFF -DCMAKE_EXPORT_COMPILE_COMMANDS:BOOL=TRUE -DCMAKE_BUILD_TYPE:STRING=Debug -H/home/user/repos/iree -B/home/user/repos/iree/build/ASAN-NoEmitC -G Ninja

Build
/usr/local/bin/cmake --build /home/user/repos/iree/build/ASAN-NoEmitC --config Debug --target all -j 50 --

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants