Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration option to show last notes when not available for a given date #35

Open
ioanniswd opened this issue Apr 30, 2020 · 9 comments
Assignees
Labels
new feature New feature or request

Comments

@ioanniswd
Copy link
Collaborator

When on Monday, while not having worked on the weekend, I would like to be able to run stup show and see what I noted on Friday.

@ghost
Copy link

ghost commented Apr 30, 2020

Doesn't it ask you if you want to see last notes (i.e. if none for the weekend are present, those from Friday)?

@iridakos
Copy link
Owner

I think it would be nice to add a configuration setting show_last_when_missing with values true/false.

When in effect, the show action should inform that it didn't find notes for the given date and that it will show the notes found at the latest date with notes before the given one without prompting for confirmation.

@iridakos iridakos added the new feature New feature or request label Apr 30, 2020
@ghost
Copy link

ghost commented Apr 30, 2020

What about making it more general (edit file etc.)? Something like --assume-yes and --assume-no.

@iridakos
Copy link
Owner

@tiosgz Nice idea! I will open an issue to allow this flag and respect in those paths that we would expect y/n.

This issue though is very valid (regardless of the aforementioned flag). Users should be able to default to latest date notes without having to always append --assume-yes/--assume-no

@iridakos
Copy link
Owner

@all-contributors please add @ioanniswd for ideas.

@allcontributors
Copy link
Contributor

@iridakos

I've put up a pull request to add @ioanniswd! 🎉

@ioanniswd
Copy link
Collaborator Author

The config for show_last_when_missing seems ideal.

@iridakos
Copy link
Owner

iridakos commented May 1, 2020

@ioanniswd I can work on this but if you have already started working on this let me know to skip, thanks!

@iridakos iridakos self-assigned this May 1, 2020
@iridakos iridakos changed the title Feature Request: Config to set yesterday equal to previous Friday when on Monday Add configuration option to show last notes when not available for a given date May 1, 2020
@ioanniswd
Copy link
Collaborator Author

Was this fixed with 97c6028 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants