Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "Add viewport scroll information to PDFAccessibilityTree"
This reverts commit c2f0727. Reason for revert: This change is causing regression. Bounding box calculation of a given element requires the |kScrollX| and |kScrollY| positions. In case of PDF there is a scroll element which lives outside the PDF node. The scroll element also reports scroll positions. During calculation of bounding boxes in AXTree::RelativeToTreeBoundsInternal |kScrollX| and |kScrollY| are applied twice. Original change's description: > Add viewport scroll information to PDFAccessibilityTree > > This CL adds following information to PDFAccessibilityTree > - ax::mojom::IntAttribute::kScrollXMin > - ax::mojom::IntAttribute::kScrollXMax > - ax::mojom::IntAttribute::kScrollX > - ax::mojom::IntAttribute::kScrollYMin > - ax::mojom::IntAttribute::kScrollYMax > - ax::mojom::IntAttribute::kScrollY > > It enables partial implementation of IScrollProvider, following methods > will work with this change > - IScrollProvider::get_HorizontallyScrollable > - IScrollProvider::get_VerticallyScrollable > - IScrollProvider::get_HorizontalScrollPercent > - IScrollProvider::get_VerticalScrollPercent > > This information is required by Screen readers to announce the current > scroll position and extent of scroll to the user. > > Tests: The best way to test this change will be through browser tests. > However, it requires the second part of the change, detailed in the > associated bug, to be completed. > > Bug: 1034521 > Change-Id: I629b2773c75f2b6b222d339cd0ae01799d695295 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985821 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Commit-Queue: Virender Singh <virens@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#728843} TBR=dcheng@chromium.org,thestig@chromium.org,mohitb@microsoft.com,virens@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. (cherry picked from commit 05d6d36) Bug: 1034521 Change-Id: I15675f9ba604be96e9c50c9bea1dbe84ef8c9a0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041714 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#739108} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043339 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/branch-heads/4044@{#198} Cr-Branched-From: a6d9daf-refs/heads/master@{#737173}
- Loading branch information
Showing
11 changed files
with
7 additions
and
56 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters