Skip to content

Commit

Permalink
prefs: disable "Use a web service to help resolve navigation errors"
Browse files Browse the repository at this point in the history
This goes towards reducing promiscuous outbound requests to
some central services.

Impl. details:
Set alternate_error_pages to be disabled by default.
  • Loading branch information
jengelh committed Apr 15, 2023
1 parent fdaec88 commit 330388c
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion chrome/browser/net/dns_probe_browsertest.cc
Expand Up @@ -209,7 +209,7 @@ void DnsProbeBrowserTest::SetUpOnMainThread() {
NetErrorTabHelper::set_state_for_testing(NetErrorTabHelper::TESTING_DEFAULT);

browser()->profile()->GetPrefs()->SetBoolean(
embedder_support::kAlternateErrorPagesEnabled, true);
embedder_support::kAlternateErrorPagesEnabled, false);

ASSERT_TRUE(embedded_test_server()->Start());

Expand Down
2 changes: 1 addition & 1 deletion chrome/browser/net/profile_network_context_service.cc
Expand Up @@ -392,7 +392,7 @@ void ProfileNetworkContextService::UpdateAdditionalCertificates() {
void ProfileNetworkContextService::RegisterProfilePrefs(
user_prefs::PrefRegistrySyncable* registry) {
registry->RegisterBooleanPref(
embedder_support::kAlternateErrorPagesEnabled, true,
embedder_support::kAlternateErrorPagesEnabled, false,
user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
registry->RegisterBooleanPref(prefs::kQuicAllowed, true);
registry->RegisterBooleanPref(prefs::kGloballyScopeHTTPAuthCacheEnabled,
Expand Down
2 changes: 1 addition & 1 deletion weblayer/browser/browser_context_impl.cc
Expand Up @@ -291,7 +291,7 @@ void BrowserContextImpl::RegisterPrefs(
// potential use cases in the future, as it is used for various purposes
// through //chrome).
pref_registry->RegisterBooleanPref(
embedder_support::kAlternateErrorPagesEnabled, true);
embedder_support::kAlternateErrorPagesEnabled, false);
pref_registry->RegisterListPref(
site_isolation::prefs::kUserTriggeredIsolatedOrigins);
pref_registry->RegisterDictionaryPref(
Expand Down

0 comments on commit 330388c

Please sign in to comment.