Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the iridiumskyblock.fly true permission gives you the /is fly active in executable in all worlds #857

Closed
Overzing opened this issue May 21, 2024 · 6 comments
Assignees
Labels
bug Something isn't working unconfirmed An issue that needs further investigation

Comments

@Overzing
Copy link

Overzing commented May 21, 2024

Describe the bug
The true iridiumskyblock.fly permission allows you to use the /is fly command in all worlds, but it should only be enableable on your island. While the fly booster makes you choose whether to put is fly for members_in_territory or members_anywhere. In theory, however, the iridiumskyblock.fly permission should make you do /is fly only on your island and not in all worlds. In fact, I removed level two of the fly booster which gave the members_anywhere fly (effect) and left only level one which gave, as it should be, the fly usable only on the island. At most I recommend modifying it by putting iridiumskyblock.fly.onlyisland and iridiumskyblock.fly.anywhere but in any case it makes no sense if it is called /is fly

To Reproduce
Steps to reproduce the behavior:

  1. give you permission: iridiumskyblock.fly
  2. Using /is fly in the island and in theory it works as expected
  3. You go to another world, which on servers is usually the spawn, and the /is fly command makes you do it anyway. Should not...

Expected behavior
A clear and concise description of what you expected to happen.

Server and Plugin Version
This server is running Paper version git-Paper-318 (MC: 1.20.2) (Implementing API version 1.20.2-R0.1-SNAPSHOT) (Git: 9271ee7)
You are running the latest version
Plugin version: 4.0.9.1

Screenshots

Logs

Additional context
flightEnhancement:
enabled: true
type: "BOOSTER"
item:
material: "FEATHER"
amount: 1
displayName: "&3&lꜰʟɪɢʜᴛ ʙᴏᴏꜱᴛᴇʀ"
headData: null
headOwner: null
headOwnerUUID: null
model: null
lore:
- "&7Ottieni accesso al volo."
- ""
- "&3&lɪɴꜰᴏʀᴍᴀᴢɪᴏɴɪ"
- "&8&l • &7Tempo rimanente: &b%timeremaining_hours% ore, %timeremaining_minutes%
\ minuti e %timeremaining_seconds% secondi"
- "&8&l • &7Livello attuale: &b%current_level%"
- "&8&l • &7Costo potenziamento: &b$%cost%"
- ""
- "&8 ▸ &7Clicca sinistro per acquistare il livello &b%next_level%."
slot: 16
levels:
1:
minLevel: 1
money: 10000
bankCosts:
Crystals: 5.0
enhancementAffectsType:
- "MEMBERS_IN_TERRITORY"

@Overzing Overzing added bug Something isn't working unconfirmed An issue that needs further investigation labels May 21, 2024
@Overzing
Copy link
Author

Overzing commented May 21, 2024

As you can see, I can do /is fly even if I'm in another world
Screenshot_1

@PeachesMLG
Copy link
Member

PeachesMLG commented May 22, 2024

Do you only have 1 level for the flight here?

By Default, level 1 allows you to fly within your own island and level 2 allows you to fly anywhere.

@PeachesMLG
Copy link
Member

oh, nevermind you mean when you have the permission.

This was a deliberate choice by me, let me have a think about how this can be done better

@PeachesMLG
Copy link
Member

We just discussed it, we will probabbly have a iridiumskyblock.fly and a iridiumskyblock.fly.anywhere permission

@Overzing
Copy link
Author

Exactly, thanks

@Overzing
Copy link
Author

Do you only have 1 level for the flight here?

I removed level two because I didn't want them to have the fly everywhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working unconfirmed An issue that needs further investigation
Projects
None yet
Development

No branches or pull requests

4 participants