Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid cross-device link #71

Closed
IrishPrime opened this issue Jan 17, 2020 · 0 comments · Fixed by #74
Closed

Invalid cross-device link #71

IrishPrime opened this issue Jan 17, 2020 · 0 comments · Fixed by #74
Assignees
Labels

Comments

@IrishPrime
Copy link
Owner

IrishPrime commented Jan 17, 2020

The utilities used to move/organize files do not support moving files between devices.

DEBUG    Creating and/or moving to: /mnt/data/Videos/TV/Watchmen/Season 01
ERROR    [Errno 18] Invalid cross-device link: 'Watchmen.S01E07.720p.WEB.h264-TBS[rarbg]/Watchmen -01.07- An Almost Religious Awe.mkv' -> '/mnt/data/Videos/TV/Watchmen/Season 01/Watchmen -01.07- An Almost Religious Awe.mkv'

Switching from os.rename to shutil.move should resolve the issue.

@IrishPrime IrishPrime added the bug label Jan 17, 2020
@IrishPrime IrishPrime self-assigned this Jan 17, 2020
IrishPrime added a commit that referenced this issue May 4, 2020
Add support for `pathlib` and use it to handle generating file paths
and extracting information from them rather than `os.path`.

Add a `nielsen.files` module which handles most of the underlying file
operations (making calls out to `shutil` for things like `chown` and
`move`). This abstraction allows not only for more reusable code, but
smaller functions to test and removes the overhead of a lot of context
for the API level functions (most notably `organize_file`).

Favor returning `Path` objects from API functions that modify files in
some way. Returning the most up-to-date version of the `Path` object
allows the API to be more composable and extendable.

Use an intermediate value for defining the filename format for processed
files. This opens up possibilities for customization.

Bump version to `2.1.0`.

Resolves #71.

Resolves #73.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant