Use pathlib for handling file paths and manipulation #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for `pathlib` and use it to handle generating file paths and extracting information from them rather than `os.path`. Add a `nielsen.files` module which handles most of the underlying file operations (making calls out to `shutil` for things like `chown` and `move`). This abstraction allows not only for more reusable code, but smaller functions to test and removes the overhead of a lot of context for the API level functions (most notably `organize_file`). Favor returning `Path` objects from API functions which modify files in some way. Returning the most up-to-date version of the `Path` object allows the API to be more composable and extendable. Resolves #73.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
pathliband use it to handle generating file pathsand extracting information from them rather than
os.path.Add a
nielsen.filesmodule which handles most of the underlying fileoperations (making calls out to
shutilfor things likechownandmove). This abstraction allows not only for more reusable code, butsmaller functions to test and removes the overhead of a lot of context
for the API level functions (most notably
organize_file).Favor returning
Pathobjects from API functions that modify files insome way. Returning the most up-to-date version of the
Pathobjectallows the API to be more composable and extendable.
Use an intermediate value for defining the filename format for processed
files. This opens up possibilities for customization.
Resolves #71.
Resolves #73.