[MRG] Confusion matrix bug #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had changed the convention for datapacks so that UNK was part of the labels index starting 0 Previously UNK was excluded, but the labels were indexed starting at 1 But it never occurred to me to update the code that builds confusion matrices not to have the +1 logic.
|
Huh, I must have had the A* doc thing in my master branch. Sorry, am so used to just pushing to the repo I haven't really had the practice in working exclusively by theme branch and pull request. This sort of makes me appreciate Darcs a lot. |
|
Also not a type error and not something that would have been caught with Haskell. |
|
Dropping this PR to consolidate with report-tweaks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GAH! Stupid Eric Bug