[MRG + 1] fixes to intra/inter parser #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were trying to be concise and picking out sentences by the subgrouping by the second EDU only (I think this must have been to avoid looking at the fake root), but this completely ignores the existence of cross-sentential links. In fact any cross-sentential edge into the sentence is included for consideration.
Account for the possibility that subgroupings may be local
Looks like this code was never exercised
I think this comes up when trying to use the local decoder with head to head decoding mode
GAH! set_graph is a bad name for a non-mutating method
We were assuming the underlying harness would accept IntraInterPair(LearnerConfig) which isn't always the case.
moreymat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intra/inter stuff wasn't really properly tested when we switched to the new DataPacks Everywhere approach. Note that it may be worth running these in irit-rst-dt
I'm investigating a separate issue with the sentence/doc-level oracles