Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional documentation for DigiSpark boards #54

Closed
11 tasks done
drechc opened this issue Jun 20, 2021 · 2 comments
Closed
11 tasks done

Additional documentation for DigiSpark boards #54

drechc opened this issue Jun 20, 2021 · 2 comments

Comments

@drechc
Copy link
Contributor

drechc commented Jun 20, 2021

Bug Report

Board

  • Digispark board

IDE

  • Arduino IDE

IR-Protocol

  • NEC

Example to reproduce the issue

  • SimpleReceiver

Version

Current behavior

None of the examples successfully compile using the "official" (but outdated) Digistump core. (Various errors due to different compiler versions, missing pin definitions, etc).

When using the ATtinyCore by SpenceKonde with the "Micronucleus/Digispark Pro" board and the "DigiSpark Pro" pin mapping, the functions in digitalWriteFast.h do not use the same pin numbers as the rest of the core.

Expected behavior

Documentation should include a reference to the newer and better DigiSpark core at:
https://github.com/ArminJo/DigistumpArduino

It would also be helpful to note the "New Style" pin mapping must be selected when using the ATtinyCore and the "Micronucleus/Digispark Pro" board.

checklist:

  • I have read the README.md file thoroughly.
  • I have searched existing issues to see if there is anything I have missed.
  • I have browsed the examples for one, that matches my use case.
  • Any code referenced is provided and if over 30 lines a gist is linked INSTEAD of it being pasted in here.
  • The title of the issue is helpful and relevant.
  • I checked, if at least one of the examples was working.

** We will start to close issues that do not follow these guidelines as it doesn't help the contributors who spend time trying to solve issues if the community ignores guidelines!**

@ArminJo
Copy link
Collaborator

ArminJo commented Jun 20, 2021

Thanks for the reporting! Fixed by modifying digitalWriteFast.h

@drechc
Copy link
Contributor Author

drechc commented Jun 21, 2021

That's a neat trick, I couldn't think of a clean way to to do it... Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants