Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs? #6

Closed
andre-nguyen opened this issue Nov 22, 2022 · 2 comments
Closed

Update docs? #6

andre-nguyen opened this issue Nov 22, 2022 · 2 comments

Comments

@andre-nguyen
Copy link

Hi

The readme mentions that

events-executor/README.md

Line 27 in 6f4343f

- The executor is broken with Fast-DDS in Humble. The following PR fixes the problem: https://github.com/ros2/rmw_fastrtps/pull/619

Now that ros2/rmw_fastrtps#619 is merged in, is this not an issue anymore?
@alsora
Copy link
Collaborator

alsora commented Nov 22, 2022

Yes! Thanks for pointing it out.
I will update the docs accordingly.

@alsora
Copy link
Collaborator

alsora commented Dec 9, 2022

Hi, we just updated the instructions in the README!
https://github.com/irobot-ros/events-executor

I'm closing this issue

@alsora alsora closed this as completed Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andre-nguyen @alsora