[irods/libs3#24] Referring to the new libs3 library. (4-2-stable) #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, one thing did change here: "enable_sha" does not exist in the build script for 4-2-stable. I just removed it here. |
|
Nice catch. |
|
Is this ready? |
|
Would prefer confirmation that this works from @JustinKyleJames but I don't have any qualms with merging. Despite the issue being closed, I believe this is required for irods/irods_resource_plugin_s3#2104 to be resolved in 4.2.12.x for the S3 resource plugin. |
|
needs a #, then a merge. |
alanking
force-pushed
the
s3_changes.42s
branch
from
b5bfe9a
to
eb6aa45
Compare
|
Oops, sorry. Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses irods/libs3#24
Cherry-picked from #183
I haven't tested this yet. Will await confirmation from @JustinKyleJames