[_6169] updates for metaclass, test generation (4-2-stable) #6206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 24, 2022
d-w-moore
changed the title
|
this seems fine for now - using six for 4-2-stable is good/necessary. eventually test_all_rules.py can get refactored / go away / be absorbed by the other test suites. |
|
so yes, please # it. |
trel
reviewed
Feb 28, 2022
scripts/irods/test/test_all_rules.py
Outdated
| @@ -236,6 +236,7 @@ def filter_rulefiles(rulefile): | |||
| "rulemsiSysReplDataObj", | |||
| "rulemsiNoChkFilePathPerm", | |||
| "rulemsiNoTrashCan", | |||
| "rulemsiSetRescSortScheme.r", | |||
There was a problem hiding this comment.
oops , ... right. Hmph.
|
Uhm.... actually, there is an extra commit where incomplete tests are skipped. (Existed on main but not here, until my force push just now - but that's how it was tested.) Sorry about that. If that's cool , then I'll go ahead and # as requested. |
|
squash it all down, get it running cleanly, and then # it. yes please. |
|
I'll test again with the .r taken out then.... on both branches. |
|
wait til irods/irods_client_icommands#277 is #'d and approved, then merge together with this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
sixmodule's portable metaclass syntax (instead of __metaclass__ which won't work starting in Python3). More importantly we use-rin irule invocations to guarantee a nonzero rule code causes the tests generated from rule file directories to return the appropriate pass / fail status to the testing framework. We target: