-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#6137] Renamed variables in irods_configuration_keywords.hpp (main) #6332
Conversation
Please confirm that our plugins and shipped clients still work with these changes. Otherwise, seems fine to me. Would like an opinion from @trel and/or @SwooshyCueb as well. |
No strong opinions here. Not as familiar with most of these. Current changes appear to just move |
Cool. I'll leave this PR as is and plan to handle the plugins. And yes, I think the use of |
03b935a
to
59879ce
Compare
14b3f37
to
f6e8467
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good to go, barring any other comments
Passed core tests. |
Will add the #'s soon |
Added # |
KW_
be used instead ofKW_CFG_
?Notice that the data type for these variables has changed from
std::string
toconst char* const
.std::string_view
would work, but it required adjusting internal APIs and function call invocations. Either way,const char* const
provides a lot of flexibility and doesn't break existing APIs.