-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#7531,#7532] Bump version number and roll our own CMake package version file (main) #7535
Conversation
c6dd330
to
3c336fb
Compare
This PR and the listed companion PRs are ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems correct. I didn't check everything.
Are there tools that help with testing things like this?
Does it make since to introduce some type of testing mechanism for this?
Please resolve the clang-format report too. |
None that I know of. I did some basic testing myself by commenting out some
Only if we end up changing the version file more than once in a blue moon, which I don't see happening. |
I'm kind of surprised there aren't tools for testing cmake code. Sounds like an opportunity to help the c/c++ ecosystem. Anyway, happy to hear the version file won't need to be touched often. |
Not so much that there aren't tools for testing CMake code (I think there are) but that there aren't any tools (that I know of) for testing input files that generate CMake code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good/ready to me.
Let's get one more approval before pounding.
f1059c7
to
51da740
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple things...
51da740
to
d2c54b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is exciting stuff... Very nice comments in the IRODSConfigVersion file
d2c54b0
to
f9ca553
Compare
f9ca553
to
d047712
Compare
# it when ready |
d047712
to
b576ef3
Compare
#'d |
In service of #7531
Addresses #7532
Submitting this separately from my libstdc++ PRs, as I want it to land first.
Companion PRs: