Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SHA1, SHA-512, and ADLER-32. Use client setting. #9

Closed
JustinKyleJames opened this issue Feb 3, 2021 · 1 comment
Closed

Add SHA1, SHA-512, and ADLER-32. Use client setting. #9

JustinKyleJames opened this issue Feb 3, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@JustinKyleJames
Copy link

JustinKyleJames commented Feb 3, 2021 •
edited
Loading

  1. Add SHA1, SHA-512, and ADLER-32.
  2. Use client setting and calculate checksums on client.
  3. Store checksums in metadata with timestamp.
  4. Determine if recalculation by comparing the timestamp with object modify time (if metadata for that algorithm exists).

See [#9]
JustinKyleJames added a commit to JustinKyleJames/irods that referenced this issue Feb 3, 2021
@JustinKyleJames
[5392] added additional hash algorithms
71f1faf 
see [irods/irods_client_globus_connector#9]

sha512
sha1
adler32
JustinKyleJames added a commit to JustinKyleJames/irods that referenced this issue Feb 3, 2021
@JustinKyleJames
[5392] added additional hash algorithms
5640ebb 
see [irods/irods_client_globus_connector#9]

sha512
sha1
adler32
This was referenced Feb 3, 2021
Merged
Merged
JustinKyleJames added a commit to JustinKyleJames/irods that referenced this issue Feb 23, 2021
@JustinKyleJames
[5392] added additional hash algorithms
fa05c3a 
see [irods/irods_client_globus_connector#9]

sha512
sha1
adler32
JustinKyleJames added a commit to JustinKyleJames/irods that referenced this issue Mar 3, 2021
@JustinKyleJames
[5392] added additional hash algorithms
ceb922e 
see [irods/irods_client_globus_connector#9]

sha512
sha1
adler32
JustinKyleJames added a commit to JustinKyleJames/irods that referenced this issue Mar 3, 2021
@JustinKyleJames
[5392] added additional hash algorithms
70a91ec 
see [irods/irods_client_globus_connector#9]

sha512
sha1
adler32
JustinKyleJames added a commit to JustinKyleJames/irods that referenced this issue Mar 3, 2021
@JustinKyleJames
[5392] added additional hash algorithms
7601f2d 
see [irods/irods_client_globus_connector#9]

sha512
sha1
adler32
JustinKyleJames added a commit to JustinKyleJames/irods that referenced this issue Mar 4, 2021
@JustinKyleJames
[irods#5392] added additional hash algorithms
c7df4dd 
see [irods/irods_client_globus_connector#9]

sha512
sha1
adler32
JustinKyleJames added a commit to JustinKyleJames/irods that referenced this issue Mar 4, 2021
@JustinKyleJames
[irods#5392] added additional hash algorithms
5a45e1f 
see [irods/irods_client_globus_connector#9]

sha512
sha1
adler32
trel pushed a commit that referenced this issue Mar 4, 2021
@JustinKyleJames @trel
[#9] Added new hash algorithms support
af4237e 
1. Add adler32, sha512, and sha1.
2. Calculate hash on client.
3. Store hash in metadata with timestamp.
4. When hash is request, see if metadata exists and compare to timestamp.
   A.  If metadata exists for hash scheme and is not out-of-date, return hash.
   B.  If metadata exists for hash scheme but is out-of-data, remove metadata, calculate hash, and write new metadata.
   C.  If metadata does not exist, calculate hash and write new metadata.

Other changes:

1. Changed globus_gridftp_server_iRODS.c to globus_gridftp_server_iRODS.cpp
2. Update CMakeLists.txt so build directory does not have to be CMAKE_SOURCE_DIRECTORY and so the GLOBUS_HOME defaults to /usr.
3. Update README.md to reflect changes in how cksum works.  The client calculates its own checksums rather than using iRODS checksum so the iRODS setting no longer applies.
4. Update README.md to provide instructions when installing from pre-built packages.
5. Updated CMakeLists.txt to use iRODS environment.
6. Remove stuff for old iRODS versions.
trel pushed a commit to irods/irods that referenced this issue Mar 4, 2021
@JustinKyleJames @trel
[#5392] added additional hash algorithms
f300d12 
see [irods/irods_client_globus_connector#9]

sha512
sha1
adler32
trel pushed a commit to irods/irods that referenced this issue Mar 4, 2021
@JustinKyleJames @trel
[#5392] added additional hash algorithms
bd4fced 
see [irods/irods_client_globus_connector#9]

sha512
sha1
adler32
@JustinKyleJames
Copy link
Author

Closing this issue as the changes have been merged.

@trel trel added the enhancement New feature or request label May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trel @JustinKyleJames