-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade pip to 20.3.4 before installing minio in test hook #2110
Comments
@alanking Do you know what needs to be done for this in main? Is it just the same changes but with python2 replaced with python3? Is the minio 6.0.2 version selection still required? (Note that I believe it isn't required as it was only required for python2 compatibility.) If you don't know I can play around with it and test it out. |
If things are working as expected in main, then we probably don't need to do anything. I'm guessing we needed to do this in 4-2-stable due to having to support older platforms, but the newer platforms in 4.3.x will have a new enough pip so this isn't an issue. Thoughts? If agreed, please remove checkboxes (or just remove the "main" checkbox) and close. Thanks! |
Oops, I guess I could answer the question... I think that if things aren't working in main, then we just need to upgrade to the latest minio that can be used on all the platforms. In short, no, I don't know what needs to be done for main. :) |
@alanking Pinning pip to 20.3.4 did work for me but I can back out of that change if we want. Just let me know. |
After some discussion, we decided that we should set 20.3.4 as the minimum version and @JustinKyleJames will update #2130 to reflect that. |
I changed it to pip>=20.3.4. This passed tests. |
@JustinKyleJames - Please checkbox and close. Thanks! |
Upgrade pip to 20.3.4 before installing minio in test hook. This is required to install minio.
The text was updated successfully, but these errors were encountered: