[#2180,#2183] Add missing curl include to request_context.h and fix some tests (main) #2189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Way more tests pass with this PR than with tip of main, but some still fail. This PR fixes some of the tests, not all of them. |
alanking
approved these changes
Apr 26, 2024
|
#'d |
|
actually wait, don't merge yet. just spotted a funky indentation |
|
Okay, now you're good to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2180
Addresses #2183
Since this needs to get in for 4.3.2, here is a PR with the non-
alloca()commits from #2181.