Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

お気に入り画面のアイテムタブの作成 一個前のプルリクはクローズしました #29

Merged
merged 52 commits into from
Oct 24, 2021
Merged

お気に入り画面のアイテムタブの作成 一個前のプルリクはクローズしました #29

merged 52 commits into from
Oct 24, 2021

Commits on Oct 16, 2021

  1. アイテムタブ用のEntityを定義した

    @nemo-855
    nemo-855 committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    f6ca085 View commit details
    Browse the repository at this point in the history

  2. favorite_item_description作成

    @nemo-855
    nemo-855 committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    64b481d View commit details
    Browse the repository at this point in the history

  3. FavoriteItemFragmentで無駄にbindingをFragmentのメンバ変数にしていたところを修正

    @nemo-855
    nemo-855 committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    358dbc8 View commit details
    Browse the repository at this point in the history

  4. FavoriteItemFragmentでGroupieAdapterとGridLayoutManager.SpanSizeLookupの… 

    …カスタムクラスを作った
    @nemo-855
    nemo-855 committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    af3345e View commit details
    Browse the repository at this point in the history

  5. FavoriteItemFragmentでGridLayoutのRecyclerViewを表示する処理実装

    @nemo-855
    nemo-855 committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    8a1abb6 View commit details
    Browse the repository at this point in the history

  6. FavoriteItemFragmentでリストに表示するようのモデルクラスを定義して、ランダムなリストを作る関数を作成

    @nemo-855
    nemo-855 committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    1dc0358 View commit details
    Browse the repository at this point in the history

  7. favorite_item_descriptionのレイアウトを整えた

    @nemo-855
    nemo-855 committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    ac44925 View commit details
    Browse the repository at this point in the history

  8. FavoriteItemDiscriptionで画像表示の処理実装

    @nemo-855
    nemo-855 committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    dfe2375 View commit details
    Browse the repository at this point in the history

  9. favorite_item_descriptionで画像サイズ修正

    @nemo-855
    nemo-855 committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    4dcdadb View commit details
    Browse the repository at this point in the history

  10. FavoriteItemFragmentでアイテムのリストを取得する導線を修正

    @nemo-855
    nemo-855 committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    5d04552 View commit details
    Browse the repository at this point in the history

  11. FavoriteItemFragmentにAndroidEntryPointをつけた

    @nemo-855
    nemo-855 committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    0923e29 View commit details
    Browse the repository at this point in the history

  12. FavoriteItemCellの引数名を修正した

    @nemo-855
    nemo-855 committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    1ec1d72 View commit details
    Browse the repository at this point in the history

  13. BrandItem変数名修正

    @nemo-855
    nemo-855 committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    37155e1 View commit details
    Browse the repository at this point in the history

  14. fragment_favorite_new_itemの内部をRecyclerViewのみにした

    @nemo-855
    nemo-855 committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    37d7029 View commit details
    Browse the repository at this point in the history

  15. fragment_favoriteの不要なlayout_behavior削除

    @nemo-855
    nemo-855 committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    97f1b5c View commit details
    Browse the repository at this point in the history

  16. fragment_favorite coordinatorLayout周りの高さ修正

    @nemo-855
    nemo-855 committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    6391295 View commit details
    Browse the repository at this point in the history

  17. favorite_new_item_item_cellの不要なmargin削除

    @nemo-855
    nemo-855 committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    d93a7cc View commit details
    Browse the repository at this point in the history

  18. FavoriteItemCellで動的に左右のmarginをつけるようにした

    @nemo-855
    nemo-855 committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    3d10f3b View commit details
    Browse the repository at this point in the history

  19. FavoriteItemFragmentでSpanSize指定部分のマジックナンバー回避

    @nemo-855
    nemo-855 committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    70f6e7c View commit details
    Browse the repository at this point in the history

  20. FavoriteItemFragmentで商品の情報をAPIから取ってきた前提に書き換えた

    @nemo-855
    nemo-855 committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    ac509cd View commit details
    Browse the repository at this point in the history

  21. CustomGridSpanSieLookupにadapterを直接渡すことでadapterのitemListの変更に対応できるようにした

    @nemo-855
    nemo-855 committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    40a4425 View commit details
    Browse the repository at this point in the history

  22. CustomGridSpanSieLookupのRecyclerViewにgridlayoutmanagerを渡すタイミング変更

    @nemo-855
    nemo-855 committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    f74c575 View commit details
    Browse the repository at this point in the history

  23. favorite_new_item_item_cellのmarginの付け方修正

    @nemo-855
    nemo-855 committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    b5cb6eb View commit details
    Browse the repository at this point in the history

  24. CustomGroupieAdapter内部のdefaltのリスト生成ロジック修正

    @nemo-855
    nemo-855 committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    c6be146 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2021

  1. FavoriteFragmentのEntityのprefixとディレクトリ構造を整理した

    @nemo-855
    nemo-855 committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    b577624 View commit details
    Browse the repository at this point in the history

  2. FavoriteFragmentのEntityにFavoriteItemModelを継承させてspanSizeを定義した

    @nemo-855
    nemo-855 committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    58fadfa View commit details
    Browse the repository at this point in the history

  3. ディレクトリ構造の修正によるパッケージ名修正

    @nemo-855
    nemo-855 committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    2c49fe5 View commit details
    Browse the repository at this point in the history

  4. DisplayClothsDataにhasDiscountPercentとhasCouponPriceを定義した

    @nemo-855
    nemo-855 committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    c35914a View commit details
    Browse the repository at this point in the history

  5. FavoriteItemFragmentのCustomGroupieAdapter fun updateList内部のロジックをupdat… 

    …eAsyncに修正
    @nemo-855
    nemo-855 committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    181878c View commit details
    Browse the repository at this point in the history

  6. FavoriteItemCellで動的に左右のmarginをつけるようにした

    @nemo-855
    nemo-855 committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    9ce90f3 View commit details
    Browse the repository at this point in the history

  7. favorite_new_item_item_cell margin修正

    @nemo-855
    nemo-855 committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    2f90c75 View commit details
    Browse the repository at this point in the history

  8. feat:Toolbarの作成

    @iroha-168 @nemo-855
    iroha-168 authored and nemo-855 committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    1f605f8 View commit details
    Browse the repository at this point in the history

  9. chore:コードレビュー指摘事項修正

    @iroha-168 @nemo-855
    iroha-168 authored and nemo-855 committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    c750832 View commit details
    Browse the repository at this point in the history

  10. add bindind adapter

    @Naoki-Hidaka @nemo-855
    Naoki-Hidaka authored and nemo-855 committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    581dcb0 View commit details
    Browse the repository at this point in the history

  11. to private

    @Naoki-Hidaka @nemo-855
    Naoki-Hidaka authored and nemo-855 committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    5969c30 View commit details
    Browse the repository at this point in the history

  12. FavoriteItemDiscriptionのTextViewをDataBinding対応

    @nemo-855
    nemo-855 committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    1b99071 View commit details
    Browse the repository at this point in the history

  13. FavoriteItemDescriptionでカスタムのBindingAdapterを適用できるところに適用

    @nemo-855
    nemo-855 committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    550a35d View commit details
    Browse the repository at this point in the history

  14. FavoriteItemFragmentのModelにspanSizeを持たせる方法をabstract class → interface… 

    …に変更した
    @nemo-855
    nemo-855 committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    b38c8c3 View commit details
    Browse the repository at this point in the history

  15. FavoriteItemViewModel fetchDisplayClothsListアイテム生成ロジック修正

    @nemo-855
    nemo-855 committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    84463d3 View commit details
    Browse the repository at this point in the history

  16. issameas hassamecontentの実装

    @nemo-855
    nemo-855 committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    902419b View commit details
    Browse the repository at this point in the history

  17. CustomGridSpanSizeLookupでadapter itemList -> getItemに変更

    @nemo-855
    nemo-855 committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    90f1ed1 View commit details
    Browse the repository at this point in the history

  18. merge main into create_favorite_item_tab

    @nemo-855
    nemo-855 committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    8a5086b View commit details
    Browse the repository at this point in the history

  19. Apply ktlint Format

    github bot committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    336ec4e View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2021

  1. SpanSizeInterface -> HasSpanSizeItem

    @nemo-855
    nemo-855 committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    36a89c8 View commit details
    Browse the repository at this point in the history

  2. hasSameContentAsのロジック修正

    @nemo-855
    nemo-855 committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    34fa3b2 View commit details
    Browse the repository at this point in the history

  3. FavoriteItemDescriptionのisSameAs修正

    @nemo-855
    nemo-855 committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    ec3021e View commit details
    Browse the repository at this point in the history

  4. CustomGridSpanSizeLookupのgetSpanSize修正

    @nemo-855
    nemo-855 committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    67c674d View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2021

  1. Merge branch 'create_favorite_item' of https://github.com/iroha-168/A… 

    …ndroidUITrain into create_favorite_item
    @nemo-855
    nemo-855 committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    da4e5d4 View commit details
    Browse the repository at this point in the history

  2. rename directory entity -> uiModel

    @nemo-855
    nemo-855 committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    0cd6bf9 View commit details
    Browse the repository at this point in the history

  3. FavoriteItemDescriptionのisSameAs修正

    @nemo-855
    nemo-855 committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    64146bf View commit details
    Browse the repository at this point in the history

  4. FavoriteItemDescriptionViewModelを廃止してFavoriteItemDescriptionにidを持たせた(… 

    …toString().toLongとするとException発生)
    @nemo-855
    nemo-855 committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    4ece3cf View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2021

  1. FavoriteItemDiscription -> FavoriteItemDescription

    @nemo-855
    nemo-855 committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    6c97dbd View commit details
    Browse the repository at this point in the history