Add new telemetry for block propagation #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullSoldier
force-pushed
the
telemetry-seen
branch
from
b0b827f
to
59c923e
Compare
This submits a new telemetry if the block has been successfully added. I decided to only submit this telemtry so if invalid blocks are sent, they aren't added to our data points. We also add data points for forks and not forks, so that we can measure properly.
NullSoldier
force-pushed
the
telemetry-seen
branch
from
59c923e
to
ca0d164
Compare
rohanjadvani
approved these changes
Feb 15, 2022
NullSoldier
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This submits a new telemetry if the block has been successfully added.
I decided to only submit this telemtry so if invalid blocks are sent,
they aren't added to our data points. We also add data points for forks
and not forks, so that we can measure properly.
Testing Plan
I will submit to local API with local influx attached.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.