Return a Buffer instead of a NativeNote from decryption functions #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deekerno
approved these changes
Feb 16, 2022
NullSoldier
approved these changes
Feb 16, 2022
mat-if
approved these changes
Feb 16, 2022
NullSoldier
added a commit
that referenced
this pull request
Feb 17, 2022
* Update to latest napi-rs to fix BigInt usage (#1014) * Update RpcClient routes to use ApiNamespace enum (#1013) Minor change to RpcClient to utilize the ApiNamespace enum for route definition. Since we have a non-stringly-typed enum already, using it here just minimizes the risk of a typo that breaks a route. * Move telemetry tags to fields (#1026) We are doing this to reduce cardinality. Indexes are created from the combination of measurement and tags. This means every node session ends up getting it's own indexes which blows out our cardinality and causes causes InfluxDB to stop processing data. You can read more about this issue here: https://docs.influxdata.com/influxdb/cloud/write-data/best-practices/resolve-high-cardinalityg * Fix ordering issue in creating telemetry node id (#1027) The issue is that Node.Init() happens before the telemetry node id is created for the first time. We simply move that up, and configure it on the SDK itself which gets passed to the constructed node. * fix miners:mined scanning status (#994) * Return a Buffer instead of a NativeNote from decryption functions (#1025) * feat(ironfish): Move metrics monitor inside telemetry (#1029) * feat(ironfish): Submit peer metrics in telemetry (#1030) * feat(ironfish): Move metrics monitor inside telemetry * feat(ironfish): Submit peer metrics in telemetry * Bump version to 0.1.23 (#1028) Co-authored-by: Derek Guenther <dguenther9@gmail.com> Co-authored-by: mat-if <97762857+mat-if@users.noreply.github.com> Co-authored-by: wd021 <dannywitters@gmail.com> Co-authored-by: Rohan Jadvani <5459049+rohanjadvani@users.noreply.github.com>
NullSoldier
pushed a commit
that referenced
this pull request
Feb 23, 2022
AmberKiso
pushed a commit
to AmberKiso/ironfish
that referenced
this pull request
Feb 23, 2022
AmberKiso
pushed a commit
to AmberKiso/ironfish
that referenced
this pull request
Feb 23, 2022
dguenther
pushed a commit
that referenced
this pull request
Feb 23, 2022
* Doc update 1 Remove test:slow Add referencing bugs fixed in the PR description. * Update graph explorer readme.md * Update locations of where test: commands can be run * Add request to add bugs being fixed to PRs * Update graph explorer readme * Update CONTRIBUTING.md * Bump ironfish-cli to 0.1.22 * Update to latest napi-rs to fix BigInt usage (#1014) * Update RpcClient routes to use ApiNamespace enum (#1013) Minor change to RpcClient to utilize the ApiNamespace enum for route definition. Since we have a non-stringly-typed enum already, using it here just minimizes the risk of a typo that breaks a route. * Move telemetry tags to fields (#1026) We are doing this to reduce cardinality. Indexes are created from the combination of measurement and tags. This means every node session ends up getting it's own indexes which blows out our cardinality and causes causes InfluxDB to stop processing data. You can read more about this issue here: https://docs.influxdata.com/influxdb/cloud/write-data/best-practices/resolve-high-cardinalityg * Fix ordering issue in creating telemetry node id (#1027) The issue is that Node.Init() happens before the telemetry node id is created for the first time. We simply move that up, and configure it on the SDK itself which gets passed to the constructed node. * fix miners:mined scanning status (#994) * Return a Buffer instead of a NativeNote from decryption functions (#1025) * feat(ironfish): Move metrics monitor inside telemetry (#1029) * feat(ironfish): Submit peer metrics in telemetry (#1030) * feat(ironfish): Move metrics monitor inside telemetry * feat(ironfish): Submit peer metrics in telemetry * Bump version to 0.1.23 (#1028) * Add telemetry status to status command (#1036) * feat(ironfish): Update telemetry flush and metrics intervals to 5m (#1038) * feat(ironfish): Update telemetry flush interval from 5s to 60s * Update to 5m * Update METRICS_INTERVAL * fix(ironfish): Pass in metrics and remove peer network from telemetry (#1033) * fix(ironfish): Pass in metrics and remove peer network from telemetry * s/peersCount/p2p_PeersCount * Change getStatus() RPC to use new metrics gauge (#1045) * v0.1.24 (#1044) * Doc update 1 Remove test:slow Add referencing bugs fixed in the PR description. * Update graph explorer readme.md * Update locations of where test: commands can be run * Add request to add bugs being fixed to PRs * Update graph explorer readme * Update CONTRIBUTING.md
AmberKiso
pushed a commit
to AmberKiso/ironfish
that referenced
this pull request
Feb 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In debugging issue #1022, I used mat-if/chaos (dafb58c) to help reproduce the issue. I was able to fix a bunch of the crashing on that branch with this change, but I'm not sure that this will completely address the crashing in that issue mentioned earlier.
Testing Plan
Ran the makefile and chaos script from the above commit.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.