Faucet improvements (fix bug #961)

[wd021]

Improve Faucet

• email should be a required flag in the CLI prompt (because it is required by the client)
• Too many faucet requests and You entered an invalid email. errors result in error Command failed with exit code 1., as seen in Bug #961. Improve error handling to exit gracefully here.

Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.

[ ] Yes
[x] No

[NullSoldier]

Email isn't required, as it uses your public key if you don't specify an email.

[wd021]

Oh oops, you're right. I thought it was required cause leaving email blank results in Collecting your funds... You entered an invalid email.. Turns out it submits an empty string to the API, which always fails. So we need to pass undefined if a user skips email.

Updated the PR for this.

[NullSoldier]

This PR creates a bug in that an errored command now returns an exit code 0. I do agree the error that yarn outputs is really annoying. We manage and print our own errors, so we don't need yarns. It's actually expected that non zero exit codes are returned in CLI commands, or else you can't use the CLI for programatic purposes, and you could have to artificially return 0 in all commands which we don't do.

There is unfortunately no way in yarn to suppress this for individual commands. We could use --silent in a .yarnrc but it would suppress that for build, install, and all the other commands too. This is purely an issue with people using engineering tooling to run their node, and unfortunately having to deal with the usability of using a build tool to just run the software from source.

[wd021]

Yea, that's a bit annoying. I think adding --silent in .yarnrc in the ironfish-cli folder is the best resolution. If necessary, perhaps add a line in the documentation for this.

[NullSoldier]

This is the tricky thing I was trying to point out. If you do this, it breaks all the logs for developers using yarn commands for install, build, etc because nothing is printed. Honestly, I think if you're using from source you have to be prepared to use engineering tooling and know how it works and be okay with these errors.

We're going to release NPM builds soon so 90% of users won't be running from source anymore and therefore should not be running yarn.

[wd021]

gotcha. yea, I'm not too concerned with the current error messaging. will just leave bug #961 as is then.

[NullSoldier]

This looks good, merging!