Blockchain test coverage #1092
Merged
Blockchain test coverage #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert test cases to array entries to get test name generation correct.
NullSoldier
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Increase test coverage of utils/blockchain.ts (93.61% lines).
Note: the name of the new file is blockutil.test.ts, not blockchain.test.ts due to an interaction with running
yarn test blockchain- both blockchain.test.ts files execute, but none of the "describe" nor "it" messages are printed out.Also leaving isBlockMine() untested - it's a trivial function and makes more sense to be tested with transaction.ts
Testing Plan
Yarn link, yarn test
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.