Dont create file handle first for writing #1980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason fileHandle.createWriteStream() is undefined, so use the method from the core fs module to see if this fixes it. I don't know why the original issue is happening and we have no repro. My best guess is that the users node libs are not correct.
hughy
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For some reason fileHandle.createWriteStream() is undefined, so use the
method from the core fs module to see if this fixes it. I don't know why
the original issue is happening and we have no repro. My best guess is
that the users node libs are not correct.
This potentially fixes #1972
Testing Plan
Run
ironfish chain:downloadBreaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.