Only store peers in CONNECTED or CONNECTING states #2275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dguenther
force-pushed
the
no-known-peers
branch
from
d3cea35
to
10dbb97
Compare
dguenther
commented
Oct 10, 2022
dguenther
commented
Oct 10, 2022
dguenther
changed the title
danield9tqh
reviewed
Oct 17, 2022
danield9tqh
reviewed
Oct 17, 2022
danield9tqh
reviewed
Oct 17, 2022
| @@ -424,19 +397,6 @@ export class Peer { | |||
|
|
|||
| this._address = address | |||
| this._port = port | |||
|
|
|||
| if (address === null && port === null) { | |||
There was a problem hiding this comment.
It looks like we've removed this logic but we aren't calling PeerManager.getConnectionRetry.neverRetryConnecting in place of removing this logic. Is that what we want to do? We call setWebSocketAddress in a few places where I don't think this logic has been replaced
danield9tqh
reviewed
Oct 17, 2022
danield9tqh
reviewed
Oct 17, 2022
danield9tqh
reviewed
Oct 17, 2022
danield9tqh
reviewed
Oct 17, 2022
danield9tqh
reviewed
Oct 17, 2022
danield9tqh
approved these changes
Oct 19, 2022
jowparks
reviewed
Jan 17, 2023
| existingConnection.close(new NetworkError(error)) | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Sets a WebSocket connection on the peer, moving it into the CONNECTING state if necessary. | ||
| * Ignores the connection if the peer already has a WebSocket connection. | ||
| * @param connection The WebSocket connection to set | ||
| */ | ||
| setWebSocketConnection(connection: WebSocketConnection): void { | ||
| if (this.state.type !== 'DISCONNECTED' && this.state.connections.webSocket) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Opening this as a draft to give some visibility into the work here.
TODO
Cap number of peerCandidates in the peerCandidateMap?Remove tryDispose functionTesting Plan
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.