adds rpc:token cli command #2293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds a command to retrieve or set the value of the rpcAuthToken key in internal.json `ironfish rpc:token` prints out the token, if any. `ironfish rpc:token --token=<value>` sets the token.
ygao76
approved these changes
Oct 5, 2022
|
From the security standpoint, can malicious people get the rpc token and hijack the tls calll? I assume this call needs auth if its via tls so the auth token is not exposed publicly. Can people get the auth token w/t the auth token? |
That's a good question! This will be safe because it doesn't make an RPC connection to a node or any TLS calls. It uses the SDK to read/write the local |
dguenther
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
adds a command to retrieve or set the value of the rpcAuthToken key in internal.json
ironfish rpc:tokenprints out the token, if any.ironfish rpc:token --token=<value>sets the token.Closes https://airtable.com/appIXmGgVqP9QdbCf/pagcUNImP87iLU1r7?FG6K5=recUzR97TjxBboY00
Testing Plan
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.