Dont materialize unspent notes when creating a tx #2299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullSoldier
force-pushed
the
reduce-confirmation
branch
from
ff631da
to
f532fe1
Compare
NullSoldier
changed the title
I got this error and checked that I was synced with the block chain. The error is misleading because it says your node must be synced, but your node can be synced and still get this error because it has nothing to do with being synced.
This loaded all TX when creating a note and joinin its related transaction to get its sequence.
NullSoldier
force-pushed
the
reduce-confirmation
branch
from
f532fe1
to
3fd5207
Compare
hughy
approved these changes
Oct 11, 2022
| @@ -303,7 +303,7 @@ export class Config extends KeyStore<ConfigOptions> { | |||
| tlsKeyPath: files.resolve(files.join(dataDir, 'certs', 'node-key.pem')), | |||
| tlsCertPath: files.resolve(files.join(dataDir, 'certs', 'node-cert.pem')), | |||
| maxPeers: 50, | |||
| minimumBlockConfirmations: 12, | |||
| minimumBlockConfirmations: 2, | |||
There was a problem hiding this comment.
Is this an intentional change or for testing?
There was a problem hiding this comment.
Intentional, but I snuck it into this PR. I should have wrote it in the description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This loaded all TX when creating a note and joinin its related
transaction to get its sequence.
Testing Plan
Run existing tests, and try creating a transaction on a big account.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.