Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get lastest transactions #2355

Merged
merged 7 commits into from
Oct 18, 2022
Merged

Conversation

hairtail
Copy link
Contributor

Summary

Implementation #2347

Testing Plan

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.

[ ] Yes

@hairtail hairtail requested a review from a team as a code owner October 15, 2022 07:05
Copy link
Contributor

@hughy hughy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on!

I left a few suggestions that I think could improve this

ironfish-cli/src/commands/accounts/transactions.ts Outdated Show resolved Hide resolved
ironfish/src/rpc/routes/accounts/getTransactions.ts Outdated Show resolved Hide resolved
ironfish/src/rpc/routes/accounts/getTransactions.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@hughy hughy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

ironfish/src/rpc/routes/accounts/getTransactions.ts Outdated Show resolved Hide resolved
ironfish/src/rpc/routes/accounts/getTransactions.ts Outdated Show resolved Hide resolved
@hughy hughy merged commit 1e912e0 into iron-fish:staging Oct 18, 2022
@hairtail hairtail deleted the latest-transaction branch October 19, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants