Add V2 consensus upgrade for block size limit #2378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirayadav
force-pushed
the
add-block-size-consensus
branch
from
8f9d04f
to
74696ed
Compare
mirayadav
force-pushed
the
add-block-size-consensus
branch
from
3090b6c
to
b294d9e
Compare
mirayadav
force-pushed
the
add-block-size-consensus
branch
from
b294d9e
to
4bb281a
Compare
NullSoldier
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enforce block size limit of 2 MB.
Added a new consensus upgrade for this limit on block 255000, estimated to occur on November 2, 2022 at 1:30 pm ET (block activation height updated in #2438). All users will need to upgrade by then.
Testing Plan
Added tests to
verifier.test.tsto confirm the block size limit is enforced after consensus upgrade V2.Can also test by lowering the activation height (
V2_MAX_BLOCK_SIZE) and max block size (MAX_BLOCK_SIZE_BYTES) and trying to sync - all blocks larger than max size set should be marked as invalid.Breaking Change