stop wallet rebroadcasting expired transactions #2399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we rebroadcast any transactions in the wallet that have not been added to a block. however, now that we continue to store expired transactions in the wallet we must ensure that we do not rebroadcast them. rebroadcasting expired transactions also updates them in the wallet db with the current head as submittedSequence. when this update is made they are added to the wallet db store for pending transaction hashes. they then 're-expire' and their notes are reverted to unspent (even if they have later been spent in another transaction).
NullSoldier
approved these changes
Oct 25, 2022
NullSoldier
approved these changes
Oct 25, 2022
NullSoldier
approved these changes
Oct 25, 2022
This was referenced Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
we rebroadcast any transactions in the wallet that have not been added to a block. however, now that we continue to store expired transactions in the wallet we must ensure that we do not rebroadcast them.
rebroadcasting expired transactions also updates them in the wallet db with the current head as submittedSequence. when this update is made they are added to the wallet db store for pending transaction hashes. they then 're-expire' and their notes are reverted to unspent (even if they have later been spent in another transaction).
Testing Plan
added unit test
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.