Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalization currency #2414

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Normalization currency #2414

merged 1 commit into from
Oct 27, 2022

Conversation

hairtail
Copy link
Contributor

Summary

  1. Replace BigInt & toString with CurrencyUtils.decode & CurrencyUtils.encode
  2. Use bigint for fee in verifyCanSend
  3. Remove unnecessary convert.

Testing Plan

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.

[ ] Yes

@hairtail hairtail requested a review from a team as a code owner October 26, 2022 01:53
@jowparks
Copy link
Contributor

Thanks for pulling in the changes from staging. LGTM

@NullSoldier NullSoldier merged commit 63a68c3 into iron-fish:staging Oct 27, 2022
@hairtail hairtail deleted the normalization-currency branch October 27, 2022 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NullSoldier NullSoldier NullSoldier approved these changes

@jowparks jowparks jowparks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hairtail @jowparks @NullSoldier