Estimate fee RPC endpoint #2428
Conversation
| throw new ValidationError(`No account found with name ${request.data.fromAccountName}`) | ||
| } | ||
|
|
||
| const priority = request.data.priority || 'medium' |
There was a problem hiding this comment.
If there's no priority passed in I'm wondering if it's better to default to medium or to fetch estimates for all levels?
When this is used in the CLI pay and deposit commands, will we make separate requests for each priority level?
There was a problem hiding this comment.
updated the interface
| await node.chain.addBlock(block) | ||
| await node.wallet.updateHead() | ||
| }) | ||
|
|
There was a problem hiding this comment.
It doesn't look like there is a test in here for the different priority levels, do they exist already elsewhere?
There was a problem hiding this comment.
Yeah, the test with different priority level is in https://github.com/iron-fish/ironfish/ironfish/src/memPool/feeEstimator.test.ts
| const low = await feeEstimator.estimateFee('low', account, receives) | ||
| const medium = await feeEstimator.estimateFee('medium', account, receives) | ||
| const high = await feeEstimator.estimateFee('high', account, receives) |
There was a problem hiding this comment.
For a followup PR - this will result in iterating over the notes for a transaction three times.
Maybe when TransactionBuilder lands we should explore caching a built transaction between calls to estimateFee and sendTransaction?
Summary
RPC for estimate fee. This will return the suggested fee for a proposed transaction.
Testing Plan
unit test
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.
@hughy @NullSoldier