Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make faucet only for testnet #3618

Merged
merged 5 commits into from
Mar 9, 2023
Merged

Make faucet only for testnet #3618

merged 5 commits into from
Mar 9, 2023

Conversation

ygao76
Copy link
Contributor

@ygao76 ygao76 commented Mar 7, 2023

Summary

check network Id for faucet command.

Testing Plan

local yarn start faucet

yajun@Yajuns-MBP ironfish-cli % yarn start faucet
yarn run v1.22.19
$ yarn build && yarn start:js faucet
$ tsc -b
$ cross-env OCLIF_TS_NODE=0 IRONFISH_DEBUG=1 node --expose-gc --inspect=:0 --inspect-publish-uid=httpt

::::::::::          :::::::::::::::::
::::::::::::       :::::::::::::::::::
:::::::::::::     :::::::::::::::::::::
::::::::::::::   ::::::::::::::::::::::::
 ::::::::::::: ::::::::::        :::::::::
   :::::::::::::::::::::          ::::::::::
   :::::::::::::::::::::          :::::::::
 ::::::::::::: ::::::::::        :::::::::
::::::::::::::   ::::::::::::::::::::::::
:::::::::::::     :::::::::::::::::::::
::::::::::::       :::::::::::::::::::
::::::::::           ::::::::::::::::

Enter your email to stay updated with Iron Fish:

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.

[ ] Yes

@ygao76 ygao76 requested a review from a team as a code owner March 7, 2023 20:40
Copy link
Member

@dguenther dguenther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add the chain/getNetworkInfo to the RPC docs in https://github.com/iron-fish/website ? We just added those yesterday lol

@dguenther dguenther merged commit c1b12ea into staging Mar 9, 2023
@dguenther dguenther deleted the ygao-faucet-testnet-only branch March 9, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants