Replace bigint casting with bigint literal #3624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughy
reviewed
Mar 8, 2023
danield9tqh
reviewed
Mar 8, 2023
| const MAX_256_BIT_NUM = BigInt( | ||
| '115792089237316195423570985008687907853269984665640564039457584007913129639935', | ||
| ) | ||
| const MAX_256_BIT_NUM = |
There was a problem hiding this comment.
Here do you want to do this for readability?
const MAX_256_BIT_NUM = 2n ** 256n - 1nThere was a problem hiding this comment.
could do in another change too
There was a problem hiding this comment.
I think that's clean, but I'd recommend doing it in another PR just to avoid the back-and-forth
Co-authored-by: Hugh Cunningham <57735705+hughy@users.noreply.github.com>
dguenther
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There's no reason to wrap bigints in the bigint type. You can just use literals. This only replaces some places.
Testing Plan
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.