Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add network id check for get fund rpc #3627

Merged
merged 4 commits into from
Mar 9, 2023
Merged

Conversation

ygao76
Copy link
Contributor

@ygao76 ygao76 commented Mar 8, 2023

Summary

Testing Plan

unit test

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.

[ ] Yes

@ygao76 ygao76 requested a review from a team as a code owner March 8, 2023 19:46
Copy link
Member

@dguenther dguenther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise looks good!

ironfish/src/rpc/routes/faucet/getFunds.ts Outdated Show resolved Hide resolved
Copy link
Member

@dguenther dguenther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you delete the commented code? Otherwise looks good!

ironfish/src/rpc/routes/faucet/getFunds.test.ts Outdated Show resolved Hide resolved
Co-authored-by: Derek Guenther <derek@ironfish.network>
@ygao76 ygao76 merged commit 1dd3ef9 into staging Mar 9, 2023
@ygao76 ygao76 deleted the ygao-get-fund-network-id branch March 9, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants