Feature: RPC HTTP Adapter #3630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullSoldier
reviewed
Mar 9, 2023
NullSoldier
reviewed
Mar 9, 2023
NullSoldier
reviewed
Mar 9, 2023
NullSoldier
reviewed
Mar 9, 2023
NullSoldier
reviewed
Mar 9, 2023
fix some minor linter errors as part of cleanup
danield9tqh
force-pushed
the
feat-rpc-http
branch
from
2779b8b
to
c10ee46
Compare
NullSoldier
reviewed
Mar 9, 2023
| const error = ErrorUtils.renderError(e) | ||
| this.logger.debug(`Error in HTTP adapter: ${error}`) | ||
| res.writeHead(500) | ||
| res.end(JSON.stringify({ error })) |
There was a problem hiding this comment.
This is a non RPC uniform error. We should return a uniform RPC error so they don't have to handle this specially or consumers will not be happy.
There was a problem hiding this comment.
Yea good suggestion. modified to handle more of our error types
NullSoldier
reviewed
Mar 9, 2023
NullSoldier
reviewed
Mar 9, 2023
NullSoldier
reviewed
Mar 9, 2023
NullSoldier
approved these changes
Mar 10, 2023
NullSoldier
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR proposes to add
HttpAdaptertoironfish/src/rpc/adapters. It is gated byenableRpcHttp, which defaults tofalse.To simplify things, everything will be a
POSTrequest.Testing Plan
WIP, unit tests + manual testing
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.