fixes genesis block transaction status

[hughy]

Summary

all transactions on the genesis block are confirmed.

'wallet:balance --all' shows a 'confirmed' balance of 0 for the genesis account when the chain contains only the genesis block.

fixes calculation of confirmed balance by ensuring that the range of unconfirmed sequences starts at at least 2

'wallet:transactions' shows a single 'unconfirmed' transaction for the genesis account when the chain contains only the genesis block.

fixes display of transaction status by checking if transaction has sequence equal to genesis block sequence

Testing Plan

Before:

After:

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.

[ ] Yes

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.

[ ] Yes

[ygao76]

Looks good, can you test it with regular account so it does not break any common use cases.

[hughy]

Looks good, can you test it with regular account so it does not break any common use cases.

Tested with a wallet on the Phase 3 network.

Steps:

• Send transaction from account 'test' to default account, 'hughy-if', using '--watch' to watch transaction progress

• Wait until transaction is unconfirmed

• Stop node

• View balances and transactions list to confirm that transaction status is correctly tracked as unconfirmed
  

• Restart node, continue watching transaction with 'wallet:transaction:watch' until confirmed

• View balances and transactions list to see that the transaction is labeled as confirmed